-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 6.5.0 #118
Merged
Merged
Release 6.5.0 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dbrakenhoff
commented
Sep 26, 2024
- Adds numpy 2.0 support
- Lots of code formatting improvements
- Improvements to documentation
update version
Strangely enough, Rconv=7 is too large for large order. Not clear why that wasn't a problem in the past.
If order > 5, Rconv =5. Otherwise it is 7
Notebook describing experiments in Bakker and Bot (2024)
Reference update
Notebook doesn't pass tests as execution time is too long. Will add through PR and remove from tests
* Create anisotropy_pap_posted.ipynb Add notebook for anisotropy paper. Needs to be removed from tests * Moved anisotropy notebook and removed from tests Now in notebook directory
Convergence large radius
* Ruff formatting + checks - add ruff ruff settings to pyproject.toml - use ruff gh actions - add python 3.12, remove python 3.8 - fix most ruff issues in code base (see pyproject.toml for ignore list). * Use ruff to format and lint (#114) * Use ruff to format and lint, fix all issues that came up. * Git blame: ignore ruff style changes * Looks like ruff trivialized test_import * Do not exclude examples from ruff * Remove unused computation in StripAreaSink.changetrace * Add ruff format --check in linting step * Also format the examples * Add examples ruff format to git-blame-ignore * more ruff after merge * this file shouldnt be in this PR. * speed up building docs using autoapi * formatting * more formatting --------- Co-authored-by: Huite <[email protected]>
mbakker7
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage is more realistic now, I think.
Ready to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.