Fix tests for v1.6

mbaz · Apr 3, 2024 · b6bf180 · b6bf180 · mbaz · Apr 3, 2024
1 parent ea9ef2d
commit b6bf180
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/src/Gaston.jl b/src/Gaston.jl
@@ -66,16 +66,35 @@ function showable(mime::MIME"image/svg+xml", f::Figure)
     return false
 end
 
+function gp_start()
+    global P
+    gstdin = Pipe()
+    gstdout = Pipe()
+    gstderr = Pipe()
+    gproc = run(pipeline(`gnuplot`,
+                         stdin = gstdin, stdout = gstdout, stderr = gstderr),
+                wait = false)
+    process_running(gproc) || error("There was a problem starting up gnuplot.")
+    close(gstdout.in)
+    close(gstderr.in)
+    close(gstdin.out)
+    Base.start_reading(gstderr.out)
+    P.gstdin = gstdin
+    P.gstdout = gstdout
+    P.gstderr = gstderr
+end
+
 # initialize gnuplot
 function __init__()
-    global P, gnuplot_state, GNUPLOT_VERSION
+    global gnuplot_state
 
     gnuplot_state.gnuplot_available = false
 
     try
         code = success(`gnuplot --version`)
         if code
             gnuplot_state.gnuplot_available = true
+            gp_start()
         else
             @warn ("There was a problem starting gnuplot. Gaston will be unable to produce any plots.")
         end

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -473,15 +473,23 @@ end
     @test_throws TypeError closefigure(1.0)
     @test_throws TypeError closefigure(1:2)
     # plot
-    @test_throws ArgumentError p = plot(0:10,0:11)
+    if VERSION < v"1.7-"
+        @test_throws ArgumentError p = plot(0:10,0:11)
+    else
+        @test_throws DimensionMismatch p = plot(0:10,0:11)
+    end
     #@test_throws DimensionMismatch surf([1,2],[3,4],[5,6,7])
     #@test_throws DimensionMismatch surf([1,2,3],[3,4],[5,6,7])
     #plot!
     closeall()
     @test_throws ErrorException p = plot!(0:10)
     # imagesc
     z = rand(5,6)
-    @test_throws ArgumentError imagesc(1:5,1:7,z)
+    if VERSION < v"1.7-"
+        @test_throws ArgumentError imagesc(1:5,1:7,z)
+    else
+        @test_throws DimensionMismatch imagesc(1:5,1:7,z)
+    end
     # histogram
     #@test_throws MethodError histogram(0:10+im*0:10)
     # save