fix(tagsInput): Ignore addFromAutocompleteOnly on input-blur

Ignore the addFromAutocompleteOnly option on the input-blur event and always set the element's validity.
mbenford · Dec 16, 2014 · e4767c2 · e4767c2
1 parent 9ad32fb
commit e4767c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 21 deletions.
diff --git a/src/tags-input.js b/src/tags-input.js
@@ -280,19 +280,14 @@ tagsInput.directive('tagsInput', function($timeout, $document, tagsInputConfig)
                 })
                 .on('input-focus', function() {
                     element.triggerHandler('focus');
-
                     ngModelCtrl.$setValidity('leftoverText', true);
                 })
                 .on('input-blur', function() {
-                    element.triggerHandler('blur');
-
-                    if (!options.addFromAutocompleteOnly) {
-                        if (options.addOnBlur) {
-                            tagList.addText(scope.newTag.text);
-                        }
-
-                        setElementValidity();
+                    if (options.addOnBlur && !options.addFromAutocompleteOnly) {
+                        tagList.addText(scope.newTag.text);
                     }
+                    element.triggerHandler('blur');
+                    setElementValidity();
                 })
                 .on('input-keydown', function(event) {
                     var key = event.keyCode,

diff --git a/test/tags-input.spec.js b/test/tags-input.spec.js
@@ -1287,18 +1287,6 @@ describe('tags-input directive', function() {
                 // Assert
                 expect(isolateScope.tags).toEqual([]);
             });
-
-            it('does not make the element invalid when it loses focus and there is any leftover text', function() {
-                // Arrange
-                isolateScope.newTag.text = 'foo';
-
-                // Act
-                isolateScope.events.trigger('input-blur');
-
-                // Assert
-                expect($scope.form.tags.$valid).toBe(true);
-                expect($scope.form.tags.$error.leftoverText).toBeFalsy();
-            });
         });
     });