Skip to content
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.

Allow "tab" to add tag and retain focus in the input #233

Closed
offsky opened this issue Sep 5, 2014 · 4 comments · May be fixed by #376
Closed

Allow "tab" to add tag and retain focus in the input #233

offsky opened this issue Sep 5, 2014 · 4 comments · May be fixed by #376
Labels
component: tags-input priority: low spring-cleaned status: replied type: feature
Milestone
Backlog

Comments

@offsky
Copy link

offsky commented Sep 5, 2014

When you press the "tab" key, what you have typed is turned into a tag and the focus is moved to the next input on the page.

What do you think about this: When you press the "tab" key, your tag is created and the focus remains in the input for you to enter another tag. If you press the "tab" key again (with nothing typed) then it moves the focus to the next input.

My reasoning is that "tab to complete" is a common action and I find myself getting annoyed that I can't "type, tab, type, tab, type, tab" to quickly enter multiple tags. I know that I can use "return", but for some reason that doesn't feel natural to me. You can still tab to the next field by double tabbing, so I don't think any usability is lost.
@offsky
Copy link
Author

offsky commented Sep 5, 2014

What I'm asking for may be better described as an "addOnTab" option.

@mbenford mbenford added this to the Backlog milestone Nov 21, 2014
@jeffsmohan
Copy link

I hate to comment for what's barely more than a +1, but I do think this deserves higher billing than a low-priority. I also agree that myself (and the users I've seen in user testing) consider tabbing to complete in a widget like this to be standard functionality.

I don't know how soon I'd have time, but @mbenford would you be open to a pull request for this? I'd love to make this excellent tool better!

@mbenford
Copy link
Owner

@jeffschenck I marked most of all non-bug issues as low priority so I could focus on what to work on for the next release. It's a common organization practice when you have a large backlog and need to know what to do next. It doesn't mean that this feature isn't important.

And of course you can send a PR solving this. No need to ask. :) Don't forget to read the CONTRIBUTING file before you start so you know how to format things according to the project guidelines.

topikito added a commit to topikito/ngTagsInput that referenced this issue Feb 26, 2015
@topikito
feat(tagsInput): Add addOnTab option
0a7ef95 
Add an option for the user to set if a tag should be created on pressing tab and there is some text left in it. This feature
is important because it allows a more user friendly way of adding new tabs.

Closes mbenford#233.
@topikito topikito mentioned this issue Feb 26, 2015
Open
@mbenford
Copy link
Owner

This issue was selected to be spring-cleaned by a script. More information can be found here.

If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: tags-input priority: low spring-cleaned status: replied type: feature
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

feat(tagsInput): Add addOnTab option topikito/ngTagsInput
3 participants
@jeffsmohan @mbenford @offsky