Skip to content
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.

Pasting in IE fails to work with add-on-paste #325

Closed
LoganBarnett opened this issue Dec 31, 2014 · 2 comments
Closed

Pasting in IE fails to work with add-on-paste #325

LoganBarnett opened this issue Dec 31, 2014 · 2 comments
Labels
component: tags-input priority: low status: replied type: bug
Milestone
Backlog

Comments

@LoganBarnett
Copy link
Contributor

  1. Install a Windows OS of some kind that uses IE 10 or 11.
  2. Use ng-tags-input with the option add-on-paste="true".
  3. In IE, paste the following into the input: foo,bar,bazz
  4. Expected behavior is for foo, bar, and bazz to exist as individual tags. Outcome is foo is in the input, and there are no tags.

Additionally, this error appears in the console:
TypeError: Unable to get property 'getData' of undefined or null reference
LoganBarnett added a commit to LoganBarnett/ngTagsInput that referenced this issue Dec 31, 2014
@LoganBarnett
fix(tagsInput): fix add-on-paste issue in IE
8bbb521 
Fix an error when pasting in IE. IE uses window.clipboardData
instead of putting clipboardData on the event itself.

Fixes mbenford#325.
@LoganBarnett LoganBarnett mentioned this issue Dec 31, 2014
Closed
@LoganBarnett
Copy link
Contributor Author

I'm not sure how to write a test for an IE-specific issue. Would one normally just mock the event?

FYI I've tested this manually on IE 9, 10, and 11.

@mbenford
Copy link
Owner

Thanks for reporting this issue. 👍

I use Sauce Labs to run all tests against IE10 and IE12, but since the test for that particular scenario mocks out the event, it won't ever break. :(

I think Angular should have taken care of that by abstracting away the paste event so we don't have to deal with browser differences like this one. Seems like a good PR to be sent to them. :)

@mbenford mbenford added this to the Backlog milestone Jan 10, 2015
LoganBarnett added a commit to LoganBarnett/ngTagsInput that referenced this issue Mar 13, 2015
@LoganBarnett
fix(tagsInput): fix add-on-paste issue in IE
01b1e1e 
Fix an error when pasting in IE. IE uses window.clipboardData
instead of putting clipboardData on the event itself.

Fixes mbenford#325.
LoganBarnett added a commit to LoganBarnett/ngTagsInput that referenced this issue Mar 14, 2015
@LoganBarnett
fix(tagsInput): fix add-on-paste issue in IE
3740a99 
Fix an error when pasting in IE. IE uses window.clipboardData
instead of putting clipboardData on the event itself.

Fixes mbenford#325.
LoganBarnett added a commit to LoganBarnett/ngTagsInput that referenced this issue Mar 14, 2015
@LoganBarnett
fix(tagsInput): fix add-on-paste issue in IE
3db4400 
Fix an error when pasting in IE. IE uses window.clipboardData
instead of putting clipboardData on the event itself.

Fixes mbenford#325.
Bessonov pushed a commit to Bessonov/ngTagsInput.ie8 that referenced this issue May 3, 2015
@LoganBarnett @Bessonov
fix(tagsInput): Fix add-on-paste issue in IE
c5f09bc 
Fix an error when pasting in IE. IE uses window.clipboardData
instead of putting clipboardData on the event itself.

Closes mbenford#325.
tarzan added a commit to DefactoSoftware/ngTagsInput that referenced this issue Nov 8, 2016
@tarzan
MONKEYPATCH the fix for making copy-pasting work in IE, see mbenford#325
b41bfad
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: tags-input priority: low status: replied type: bug
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(tagsInput): fix add-on-paste issue in IE LoganBarnett/ngTagsInput
2 participants
@LoganBarnett @mbenford