This repository has been archived by the owner on Nov 22, 2021. It is now read-only.
Fixes conflicting keyCode for comma #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezoerb
changed the title
|
@mbenford any updates on this? |
| */ | ||
| function validateComma(e) { | ||
| var originalEvent = e.originalEvent || e; | ||
| return (e.keyCode !== KEYS.comma) || (e.key || e.char) === ',' || originalEvent.keyIdentifier === 'U+002C'; |
There was a problem hiding this comment.
Wouldn't it be simpler to just check if any key modifier is activated?
| * FF: key | ||
| * IE: char|key | ||
| * Safari: - | ||
| * |
There was a problem hiding this comment.
These are the only properties that differ between pressing < and , so i think there's no other way to fix this.
|
Up to this! Can it be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional helper method to validate comma so a new tag won't be created when pressing
<(#334)