feat: add charset parmater #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku demo for this branch: https://rss-test-charset.herokuapp.com/ |
mbertolacci
reviewed
Apr 23, 2020
mbertolacci
reviewed
Apr 23, 2020
mbertolacci
reviewed
Apr 23, 2020
|
Thank you very much for this change, @fengkx. I have provided some comments I'd love for you to fix before I merge the branch. The other very important thing is, if the user provides an encoding that is not supported, they get this error:
I think it would be better if you added a check using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add charset parmater to test different encoding