[load] baseline trends | sas download

[mbhardwaj-msft]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
• My extension version conforms to the Extension version schema

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

[Copilot]

Copilot reviewed 41 out of 52 changed files in this pull request and generated 1 comment.

Files not reviewed (11)

• src/load/HISTORY.rst: Language not supported
• src/load/azext_load/tests/latest/recordings/test_load_test_list.yaml: File too large
• src/load/azext_load/tests/latest/recordings/test_load_test_show.yaml: File too large
• src/load/azext_load/tests/latest/recordings/test_load_test_create_with_args.yaml: Evaluated as low risk
• src/load/azext_load/tests/latest/constants.py: Evaluated as low risk
• src/load/azext_load/data_plane/load_test/commands.py: Evaluated as low risk
• src/load/azext_load/data_plane/load_test/params.py: Evaluated as low risk
• src/load/azext_load/data_plane/utils/utils.py: Evaluated as low risk
• src/load/azext_load/data_plane/utils/argtypes.py: Evaluated as low risk
• src/load/azext_load/tests/latest/helper.py: Evaluated as low risk
• src/load/azext_load/data_plane/load_test_run/custom.py: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/load/azext_load/data_plane/load_test/custom.py:352

• Ensure that the response_time_aggregate parameter is one of the allowed values in AllowedTrendsResponseTimeAggregations to prevent invalid values from being used.

response_time_aggregate=AllowedTrendsResponseTimeAggregations.MEAN.value,

Copilot reviewed 40 out of 51 changed files in this pull request and generated no comments.

Files not reviewed (11)

• src/load/HISTORY.rst: Language not supported
• src/load/azext_load/tests/latest/recordings/test_load_test_list.yaml: File too large
• src/load/azext_load/tests/latest/recordings/test_load_test_show.yaml: File too large
• src/load/azext_load/tests/latest/constants.py: Evaluated as low risk
• src/load/azext_load/data_plane/utils/argtypes.py: Evaluated as low risk
• src/load/azext_load/data_plane/utils/constants.py: Evaluated as low risk
• src/load/azext_load/data_plane/utils/models.py: Evaluated as low risk
• src/load/azext_load/data_plane/utils/utils.py: Evaluated as low risk
• src/load/azext_load/tests/latest/helper.py: Evaluated as low risk
• src/load/azext_load/tests/latest/recordings/test_load_test_create_with_args.yaml: Evaluated as low risk
• src/load/azext_load/tests/latest/test_load_baseline_trends.py: Evaluated as low risk

Comments suppressed due to low confidence (2)

src/load/azext_load/data_plane/load_test/custom.py:310

• The function set_baseline should have corresponding test cases to ensure its correctness.

def set_baseline(

src/load/azext_load/data_plane/load_test/custom.py:347

• The function compare_to_baseline should have corresponding test cases to ensure its correctness.

def compare_to_baseline(

[mitsha-microsoft]

Waiting on fixing the client side filtering.

[Copilot]

Copilot reviewed 40 out of 52 changed files in this pull request and generated 1 comment.

Files not reviewed (12)

• src/load/HISTORY.rst: Language not supported
• src/load/azext_load/tests/latest/recordings/test_load_test_list.yaml: File too large
• src/load/azext_load/tests/latest/recordings/test_load_test_show.yaml: File too large
• src/load/azext_load/tests/latest/recordings/test_load_test_create_with_args.yaml: Evaluated as low risk
• src/load/azext_load/tests/latest/constants.py: Evaluated as low risk
• src/load/azext_load/data_plane/load_test/commands.py: Evaluated as low risk
• src/load/azext_load/data_plane/load_test/params.py: Evaluated as low risk
• src/load/azext_load/data_plane/utils/utils.py: Evaluated as low risk
• src/load/azext_load/tests/latest/helper.py: Evaluated as low risk
• src/load/azext_load/data_plane/utils/argtypes.py: Evaluated as low risk
• src/load/azext_load/data_plane/load_test_run/custom.py: Evaluated as low risk
• src/load/azext_load/data_plane/utils/models.py: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/load/azext_load/tests/latest/test_load_baseline_trends.py:167

• The method '_configure_command_assert_exception' is defined twice in the file, which can lead to confusion and potential errors.

def _configure_command_assert_exception(self, message, is_show_trends=False):