-
Notifications
You must be signed in to change notification settings - Fork 12
Fixes of serialization issues and null-checks #2
Conversation
Before we can accept pull requests, you will need to sign a contribute license agreement. Please email "hello at mbientlab dot com" to request a copy. Regarding the fixes:
|
Regarding the point "What are the reproduction steps to trigger the serialization errors?" the steps to reproduce are very simple:
Regarding the point "What are the reproduction steps that have the downloadTask variable set to null during a log download?". The problem is that sometimes happens that this callback Regarding the point "downloadTask was changed to throw a fault if d/c during downloading in the previous release. Your merge reverts that, see this line in the diff." I just committed the fix. Sorry for that. |
The null pointer exception is (eventually) caused by calling That said, the NPE shouldn't happen regardless. Now knowing the root cause, I will be implementing different fix and thus will not be accepting the logging code changes in this PR. Please modify this PR to only be for the serialization code changes. Regarding the serialization fixes, the code changes look good to me. I have been adding some unit tests that expose the exceptions. When I have confirmed that this PR corrects the unit tests, I will merge it into the code base. |
I pushed some unit tests out over the weekend. Please update the PR's origin to the latest commit on master. |
While using the C# library in our Xamarin project we discovered several issues regarding serialization:
In addition to that, there were some conditions that caused null references (that were unrecoverable) in Logging.cs file regarding the variable "downloadTask". We added null-checks to prevent crashes.
NOTE: the code is already merged with version 1.0.0