Skip to content

Commit

Permalink
Make PyType errors fatal, i.e., fail CI
Browse files Browse the repository at this point in the history
Previously, they were optional, with the flag `continue-on-error: true`, which
would have the CI succeed even if this check failed. With this change, PyType
failing type checking would signal a failure in the CI.
  • Loading branch information
mbrukman committed Nov 5, 2024
1 parent 76bae4f commit 14936ef
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ jobs:

- name: Check types with PyType
run: make pytype-test
# Mark this check optional for now, in case it starts out failing.
# We will make it required once we've fixed any existing issues.
continue-on-error: true
# https://github.com/google/pytype/issues/1475
#
# PyType does not yet support Python 3.12 or later; if this step is
Expand Down

0 comments on commit 14936ef

Please sign in to comment.