-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Instead of a having a custom implementation, use the `override` implementation from the `typing_extensions` module which properly handles Python versions before 3.12 which don't yet include support for `typing.override`. Add latest `typing-extensions` to `requirements.txt`. Instead of using `/usr/bin/python` runline from each Python file, use `python` or `python3` runner which will pick up the earliest appearing Python binary which we also previously used when we installed `typing-extensions` module via `python -m pip install`. On GitHub Actions, this is not `/usr/bin/python`, so if we install using the default Python, then `/usr/bin/python` will complain of a missing package. This only appears to fail on Ubuntu 22.04, but was still annoying to track down.
- Loading branch information
Showing
8 changed files
with
11 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1 @@ | ||
# We don't need any content here, but the absence of this file breaks | ||
# actions/setup-python in GitHub Actions, e.g., | ||
# | ||
# https://github.com/mbrukman/csv2txf/actions/runs/10437183622/job/28903088310?pr=29 | ||
# | ||
# > Error: No file in /Users/runner/work/csv2txf/csv2txf matched to | ||
# > [**/requirements.txt or **/pyproject.toml], make sure you have checked out | ||
# > the target repository | ||
typing-extensions ~= 4.12.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters