refactor: unify local time and service date logic #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
force-pushed
the
cfg-service-day
branch
from
1068497 to
c79d63c
Compare
digitalcora
force-pushed
the
cfg-service-day
branch
3 times, most recently
from
528009d to
aa43035
Compare
PaulJKim
reviewed
Jan 28, 2025
* Replaces a multitude of slightly different one-off routines for translating a datetime into a "service date" with calls to a shared utility function. * Replaces a bunch of duplicated `America/New_York` strings with calls to a new utility function.
digitalcora
force-pushed
the
cfg-service-day
branch
from
aa43035 to
5d20ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
America/New_Yorkstrings with calls to a new utility function.