Moved 288px height to normal_header.scss instead of normal.scss

[deanshi]

Asana task: [extra] bus e-ink header has incorrect appearance on widget endpoint

Description

• Fixed issue where header widget height was not being set to 288px
• Removed 288px from the other two spots in bus_eink and gl_eink

Let me know if removing them/putting them here has adverse effects, I tried to check the places that I could but I'm sure I missed places.

• Tests added?

[digitalcora]

This might fix the immediate problem Mercury was having but I think there is an opportunity here to clean up just a bit more. The problem in the abstract is that we're setting the absolute sizes of components by targeting the layout slot they're placed in, rather than the component's markup itself — when the component is then rendered in isolation, not in any slot, it doesn't have the right styles.

I think we should be able to:

• Completely remove width and height for .screen-normal__header and .screen-normal__body, in the normal.scss for Bus E-ink and GL E-ink
• Move the width value as well as the height value to .normal-header in eink/normal_header.scss
• Not have to do anything for .body-normal, since absolute width and height are already defined for this (redundantly, prior to this change)

[deanshi]

Sounds like a PLAN. I'll put up the changes soon.

And if you have time, I would love a run down on how it all works from a higher level if possible so I can get a sense of how some of the code interacts with the different possible screens hahaha.

[digitalcora]

🧹 ✨ thanks!

[digitalcora]

I would love a run down on how it all works from a higher level if possible so I can get a sense of how some of the code interacts with the different possible screens

I wasn't sure how much of the Screens Architecture™ Brett had already gone over but yes, I'd love to explain, at least to the extent I know it myself!

[deanshi]

I would love a run down on how it all works from a higher level if possible so I can get a sense of how some of the code interacts with the different possible screens

I wasn't sure how much of the Screens Architecture™ Brett had already gone over but yes, I'd love to explain, at least to the extent I know it myself!

We talked about PA/ESS, but not so much about Screens in general. So any Screens Architecture™ info would be great!