feat: Consolidate 3 modals into BaseNotificationModal #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
reviewed
May 1, 2024
assets/tests/components/notificationModals/chelseaLoweredNotificationModal.test.tsx
Outdated
Show resolved
Hide resolved
firestack
reviewed
May 1, 2024
assets/src/components/notificationModals/basicNotificationModal.tsx
Outdated
Show resolved
Hide resolved
firestack
reviewed
May 2, 2024
assets/tests/components/notificationModals/inactiveStateModal.test.tsx
Outdated
Show resolved
Hide resolved
Coverage of commit
|
firestack
approved these changes
May 2, 2024
firestack
approved these changes
May 2, 2024
joshlarson
reviewed
May 2, 2024
| import { StateDispatchContext } from "../../contexts/stateDispatchContext" | ||
| import { OldCloseIcon } from "../../helpers/icon" | ||
|
|
||
| const BasicNotificationModal = ({ |
There was a problem hiding this comment.
Commenting a bit late here, but did you mean for this to be Basic or Base?
I only ask because the title of the PR says Base, and that's what I would normally have expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSX of the Chelsea Bridge modals seemed structurally copy-pasted from the Inactive Notification Modal (the classnames still referred to the Inactive Notif Modal, which seemed misleading), so it seemed logical to consolidate into BaseNotificationModal before converting that modal to the Restart UI component.
Asana Ticket: https://app.asana.com/0/1205385723132845/1206770630583768