Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a placeholder minimal-route-ladders page #2575

Merged
merged 4 commits into from
May 3, 2024
Merged

feat: Add a placeholder minimal-route-ladders page #2575

merged 4 commits into from
May 3, 2024

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson commented May 3, 2024 •
edited
Loading

@joshlarson joshlarson requested a review from a team as a code owner May 3, 2024 00:39
@joshlarson joshlarson marked this pull request as draft May 3, 2024 00:43
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Coverage of commit d0472ad

Summary coverage rate:
  lines......: 93.8% (3228 of 3443 lines)
  functions..: 73.4% (1337 of 1822 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate_web/router.ex                                         |90.2%     61|16.4%   134|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Coverage of commit 5e271dc

Summary coverage rate:
  lines......: 93.7% (3227 of 3443 lines)
  functions..: 73.4% (1337 of 1822 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate_web/router.ex                                         |90.2%     61|16.4%   134|    -      0

Download coverage report

Base automatically changed from jdl/refactor/make-nav-a-route-element to main May 3, 2024 14:06
@joshlarson joshlarson marked this pull request as ready for review May 3, 2024 14:11
@joshlarson joshlarson force-pushed the jdl/feat/placeholder-minimalist-page branch from 5e271dc to 5675f13 Compare May 3, 2024 14:56
firestack
firestack reviewed May 3, 2024
View reviewed changes
assets/src/components/app.tsx Outdated
@@ -30,6 +30,8 @@ import { isGhost, isVehicle } from "../models/vehicle"
import { TabMode } from "./propertiesPanel/tabPanels"
import { DummyDetourPage } from "./dummyDetourPage"
import inTestGroup, { TestGroups } from "../userInTestGroup"
import { MinimalLadderPage } from "./minimalLadderPage"
import inTestGroup, { TestGroups } from "../userInTestGroup"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this got duplicated somehow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Coverage of commit 72d55c8

Summary coverage rate:
  lines......: 93.7% (3226 of 3443 lines)
  functions..: 73.3% (1336 of 1822 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate_web/router.ex                                         |90.2%     61|16.4%   134|    -      0

Download coverage report

@joshlarson joshlarson merged commit 519b7fd into main May 3, 2024
15 checks passed
@joshlarson joshlarson deleted the jdl/feat/placeholder-minimalist-page branch May 3, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

Assignees
No one assigned
Labels
chromatic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlarson @firestack