Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup:feat(ts/hooks/useDetour): convert fetchFinishedDetour to use useApiCall #2605

Merged
merged 1 commit into from
May 20, 2024
Merged

cleanup:feat(ts/hooks/useDetour): convert fetchFinishedDetour to use useApiCall #2605

merged 1 commit into from
May 20, 2024

Conversation

firestack
Copy link
Member

@firestack firestack commented May 20, 2024 •
edited
Loading

Just a little bit of cleanup and simplification, makes the transition to state machines a little cleaner.

@firestack firestack self-assigned this May 20, 2024
@firestack firestack requested a review from a team as a code owner May 20, 2024 12:13
@github-actions GitHub Actions
Copy link

Coverage of commit 6ab1fed

Summary coverage rate:
  lines......: 93.6% (3241 of 3464 lines)
  functions..: 73.3% (1340 of 1827 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack mentioned this pull request May 20, 2024
Merged
@firestack firestack force-pushed the kf/cleanup/convert-finished-useapi branch from 6ab1fed to 8378733 Compare May 20, 2024 13:30
@firestack firestack enabled auto-merge (squash) May 20, 2024 13:30
@github-actions GitHub Actions
Copy link

Coverage of commit 8378733

Summary coverage rate:
  lines......: 93.6% (3241 of 3464 lines)
  functions..: 73.3% (1340 of 1827 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

hannahpurcell
hannahpurcell approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@firestack firestack merged commit b58894a into main May 20, 2024
9 checks passed
@firestack firestack deleted the kf/cleanup/convert-finished-useapi branch May 20, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees

@firestack firestack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firestack @hannahpurcell