refactor(tests): Simplify tests for RoutePropertiesCard #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
force-pushed
the
jdl/tests/simplify-rpc-tests
branch
from
6b171e7 to
d12f582
Compare
Coverage of commit
|
joshlarson
force-pushed
the
jdl/tests/simplify-rpc-tests
branch
from
d12f582 to
47d3d4b
Compare
Coverage of commit
|
joshlarson
changed the base branch from
jdl/stories/story-for-route-properties-card
to
main
joshlarson
force-pushed
the
jdl/tests/simplify-rpc-tests
branch
from
47d3d4b to
d75281d
Compare
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that a lot of the tests for
<RoutePropertiesCard />had to initialize a bunch of props that those tests didn't really care about. That cluttered up the tests and made it harder to tell what the tests actually cared about, so I copied a pattern I saw in the<DetourMap />tests.