feat: Enter the "Activated" state when "Activate Detour" button is clicked #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
Coverage of commit
|
joshlarson
force-pushed
the
jdl/feat/state-change-for-activating
branch
from
c148d42 to
81a3828
Compare
Coverage of commit
|
joshlarson
force-pushed
the
jdl/feat/state-change-for-activating
branch
from
81a3828 to
e7a3891
Compare
Coverage of commit
|
hannahpurcell
approved these changes
Aug 2, 2024
| @@ -81,4 +81,14 @@ describe("DiversionPage activate workflow", () => { | |||
|
|
|||
| expect(activateDetourButton.get()).toBeVisible() | |||
| }) | |||
|
|
|||
| test("clicking the activate button shows the 'Active Detour' screen", async () => { | |||
There was a problem hiding this comment.
non-blocking: there is not yet an "active detour" screen, so the test (appropriately, I think) checks that the old screen is gone. Should the name of the test be changed?
Suggested change
| test("clicking the activate button shows the 'Active Detour' screen", async () => { | |
| test("clicking the activate button changes screen from 'Share Detour Details'", async () => { |
There was a problem hiding this comment.
Errr - woops! Auto-merge scooped your (very accurate) comment.
But I think #2715 makes the test name accurate again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-07-31.at.10.42.36.AM.mov
Asana Ticket: https://app.asana.com/0/1205718271156548/1207935854187630/f
Subtask Of: https://app.asana.com/0/1148853526253420/1205836718156544/f
Depends on:
Activatebutton gated behind detours-list test group #2713