tests: Update selectors for "Add detour" dropdown in tests #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
firestack
reviewed
Aug 1, 2024
| @@ -557,11 +557,11 @@ describe("LadderPage", () => { | |||
| expect(container.querySelector(".c-route-ladder__header")).toBeVisible() | |||
|
|
|||
| expect( | |||
| container.querySelector(".c-route-ladder__dropdown-button") | |||
| screen.getByRole("button", { name: "1 Route Options" }) | |||
There was a problem hiding this comment.
note/nit(non-blocking): btw, I think this expect().toBeVisible() is redundant? I'd want to check, but I'm fairly certain you can't use screen.getBy to get hidden elements without passing the { hidden: true } option, and it'll stop the test if it can't find it. So both asserts that it's visible and clicks it.
await userEvent.click(
screen.getByRole("button", { name: "1 Route Options" })
)There was a problem hiding this comment.
Yeah I was thinking the same thing, but at the time I didn't want to unilaterally get rid of it.
Now it won't be unilateral!
firestack
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
looks good, left one note1 that I don't think will change anything, but in case you do want to, I disabled automerge. Feel free to ignore.
Footnotes
firestack
approved these changes
Aug 1, 2024
joshlarson
deleted the
jdl/tests/update-selectors-for-route-ladder-dropdown
branch
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #2647 (comment). At the time, #2657 hadn't been merged yet, so this couldn't be done, but that's no longer the case.
Asana Ticket: https://app.asana.com/0/1205718271156548/1207533417539273/f