Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Save detour creation snapshot to db #2729

Merged
merged 25 commits into from
Aug 26, 2024
Merged

feat: Save detour creation snapshot to db #2729

merged 25 commits into from
Aug 26, 2024

Conversation

hannahpurcell
Copy link
Collaborator

@hannahpurcell hannahpurcell commented Aug 5, 2024 •
edited
Loading

Still need to write tests and format, but wanted to gauge this approach asap

  • Tests!

@hannahpurcell hannahpurcell marked this pull request as ready for review August 5, 2024 16:20
@hannahpurcell hannahpurcell requested a review from a team as a code owner August 5, 2024 16:20
firestack
firestack reviewed Aug 9, 2024
View reviewed changes
assets/src/api.ts Outdated Show resolved Hide resolved
@hannahpurcell hannahpurcell force-pushed the hp/test-branch-saving-to-db branch from ff7f21b to ca9f3fb Compare August 20, 2024 18:35
@github-actions GitHub Actions
Copy link

Coverage of commit 8480c77

Summary coverage rate:
  lines......: 93.0% (3299 of 3547 lines)
  functions..: 72.5% (1360 of 1876 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detours.ex                                    |81.2%     16|75.0%    12|    -      0
  lib/skate_web/controllers/detours_controller.ex                 |97.8%     45|93.3%    15|    -      0
  lib/skate_web/router.ex                                         |89.1%     64|15.9%   138|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 8480c77

Summary coverage rate:
  lines......: 93.2% (3305 of 3547 lines)
  functions..: 72.5% (1360 of 1876 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detours.ex                                    |81.2%     16|75.0%    12|    -      0
  lib/skate_web/controllers/detours_controller.ex                 |97.8%     45|93.3%    15|    -      0
  lib/skate_web/router.ex                                         |89.1%     64|15.9%   138|    -      0

Download coverage report

firestack
firestack reviewed Aug 23, 2024
View reviewed changes
assets/tests/api.test.ts Outdated Show resolved Hide resolved
firestack
firestack reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll leave the review up to @joshlarson and come and look at this later once I'm back online and approve if it's still up

hannahpurcell and others added 2 commits August 23, 2024 09:49
@github-actions GitHub Actions
Copy link

Coverage of commit e2b84f1

Summary coverage rate:
  lines......: 93.0% (3299 of 3547 lines)
  functions..: 72.5% (1360 of 1876 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detours.ex                                    |81.2%     16|75.0%    12|    -      0
  lib/skate_web/controllers/detours_controller.ex                 |97.8%     45|93.3%    15|    -      0
  lib/skate_web/router.ex                                         |89.1%     64|15.9%   138|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit e2b84f1

Summary coverage rate:
  lines......: 93.0% (3299 of 3547 lines)
  functions..: 72.5% (1360 of 1876 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detours.ex                                    |81.2%     16|75.0%    12|    -      0
  lib/skate_web/controllers/detours_controller.ex                 |97.8%     45|93.3%    15|    -      0
  lib/skate_web/router.ex                                         |89.1%     64|15.9%   138|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 8603420

Summary coverage rate:
  lines......: 93.0% (3298 of 3547 lines)
  functions..: 72.4% (1359 of 1876 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detours.ex                                    |81.2%     16|75.0%    12|    -      0
  lib/skate_web/controllers/detours_controller.ex                 |97.8%     45|93.3%    15|    -      0
  lib/skate_web/router.ex                                         |89.1%     64|15.9%   138|    -      0

Download coverage report

firestack
firestack approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to leave test structure/organization and methodology review to @joshlarson but LGTM!

@firestack firestack mentioned this pull request Aug 23, 2024
Merged
@hannahpurcell
Copy link
Collaborator Author

Merging now, but would take later feedback for iteration / improvement!

@hannahpurcell hannahpurcell merged commit 788ddb2 into main Aug 26, 2024
21 checks passed
@hannahpurcell hannahpurcell deleted the hp/test-branch-saving-to-db branch August 26, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlarson joshlarson joshlarson left review comments

@firestack firestack firestack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahpurcell @joshlarson @firestack