refactor: Update boostrap breakpoints and use them for u-hide-for-mobile #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
approved these changes
Sep 9, 2024
joshlarson
deleted the
jdl/refactor/update-and-use-bootstrap-breakpoints
branch
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Asana Ticket.
We had our own custom collection of breakpoints, but Bootstrap also provides a ton of utility classes that allow us to easily make things responsive. The catch: Bootstrap's default breakpoints are different from the ones we were using.
This updates Skate's bootstrap-breakpoint variable to use our previous breakpoints, and the
u-hide-for-mobileutility class to use the bootstrap breakpoint instead of our home-rolled one.