Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Active detour panel header yellow for those in detour-pilot group #2783

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: Active detour panel header yellow for those in detour-pilot group #2783

merged 2 commits into from
Sep 13, 2024

Conversation

hannahpurcell
Copy link
Collaborator

Asana ticket

@hannahpurcell hannahpurcell requested a review from a team as a code owner September 10, 2024 21:18
firestack
firestack reviewed Sep 10, 2024
View reviewed changes
assets/src/components/detours/diversionPage.tsx
"border-bottom",
snapshot.matches({ "Detour Drawing": "Active" }) &&
userInTestGroup(TestGroups.DetoursPilot)
? "active-detour"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like --bs-bg-opacity isn't set correctly so it's not showing up, but I think we should be able to use text-bg-ui-alert ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I was wondering what wasn't showing up, but I see that things look wonky on mobile. Is that what you're talking about? I'll fix it (but also the mobile view will be reworked further later)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mainly thinking that we should be able to use the bootstrap classes for background colors and that when I tried it text-bg-ui-alert didn't work due to --bs-bg-opacity defaulting to completely transparent. I know ui-alert isn't lemon-100, so it's fine for now.

@github-actions GitHub Actions
Copy link

Coverage of commit e1cdb31

Summary coverage rate:
  lines......: 93.0% (3318 of 3567 lines)
  functions..: 72.5% (1364 of 1882 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit c6e70d4

Summary coverage rate:
  lines......: 93.0% (3318 of 3567 lines)
  functions..: 72.5% (1364 of 1882 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@hannahpurcell hannahpurcell merged commit 079309d into main Sep 13, 2024
33 checks passed
@hannahpurcell hannahpurcell deleted the hp/active-detour-panel-yellow-header branch September 13, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

@joshlarson joshlarson Awaiting requested review from joshlarson

Assignees

@firestack firestack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahpurcell @joshlarson @firestack