feat: add detour notifications to notifications module #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/asn/dn/notification
branch
2 times, most recently
from
1464bac to
7e1db17
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
7e1db17 to
2986304
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
2986304 to
d79ea2c
Compare
firestack
commented
Sep 25, 2024
firestack
commented
Sep 25, 2024
| |> select_bridge_movements() | ||
| |> select_block_waivers() | ||
| |> select_detour_info() | ||
| |> where([notification: n], n.created_at > ^cutoff_time) |
There was a problem hiding this comment.
hmm, gonna need to figure out a better way to do this now... since detours can be active for longer than the cutoff time..
There was a problem hiding this comment.
Do we even need/want to limit detour lifespan? I figured that a detour would just be active until it's deactivated.
There was a problem hiding this comment.
You're correct, but block waivers and bridge movements don't agree and do require this, so I need a way to only apply this for non detour notifications
|
I tried to add a test for logging notification creation, but was unable to, I created a followup ticket to make sure this doesn't get missed, so that we're in parity with other notifications. |
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
d79ea2c to
c231cfb
Compare
Coverage of commit
|
joshlarson
reviewed
Sep 25, 2024
joshlarson
reviewed
Sep 25, 2024
joshlarson
reviewed
Sep 25, 2024
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
0a5c2ae to
2a47520
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
5653aab to
bc3b076
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
bc3b076 to
1d7f8d7
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
1d7f8d7 to
a9659a2
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
a9659a2 to
91773c9
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
91773c9 to
d91843c
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
d91843c to
e31c806
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
e31c806 to
b3bd45d
Compare
Coverage of commit
|
joshlarson
reviewed
Sep 26, 2024
joshlarson
reviewed
Sep 26, 2024
joshlarson
reviewed
Sep 26, 2024
joshlarson
reviewed
Sep 26, 2024
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
1884c6d to
c26872e
Compare
joshlarson
approved these changes
Sep 26, 2024
Coverage of commit
|
feat(ex/notifications/detour): add virtual fields to detour notification schema feat(ex/notifications): query detour info from notifications Co-authored-by: Josh Larson <[email protected]>
firestack
force-pushed
the
kf/asn/dn/notification
branch
from
1e956b0 to
b043e49
Compare
Coverage of commit
|
Coverage of commit
|
Coverage of commit
|
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of adding detour notifications to Skate. To be able to send detour notifications, we first need to create the functions and setup for storing and retrieving this info from the database.
This will be used by
notification_serverin future PR's.The entire feature can be seen in context on the branch main...kf/asn/detour-notifications