feat(ts/notifications): create notification card for detours #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/asn/dn/fe-notifications
branch
4 times, most recently
from
ccda719 to
b0391d4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
joshlarson
reviewed
Sep 26, 2024
firestack
force-pushed
the
kf/asn/dn/fe-notifications
branch
from
b0391d4 to
6ef0c62
Compare
This comment was marked as outdated.
This comment was marked as outdated.
firestack
force-pushed
the
kf/asn/dn/fe-notifications
branch
from
6ef0c62 to
a2962f6
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
firestack
force-pushed
the
kf/asn/dn/fe-notifications
branch
from
a2962f6 to
9bb8c73
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
firestack
force-pushed
the
kf/asn/dn/fe-notifications
branch
from
9bb8c73 to
4e96ee5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
firestack
force-pushed
the
kf/asn/dn/fe-notifications
branch
2 times, most recently
from
219db59 to
998f950
Compare
This comment was marked as spam.
This comment was marked as spam.
firestack
force-pushed
the
kf/asn/dn/fe-notifications
branch
4 times, most recently
from
c1143eb to
c9889e0
Compare
firestack
force-pushed
the
kf/asn/dn/fe-notifications
branch
from
c9889e0 to
d3de5ed
Compare
hannahpurcell
approved these changes
Sep 30, 2024
firestack
commented
Oct 1, 2024
firestack
commented
Oct 1, 2024
firestack
commented
Oct 1, 2024
firestack
commented
Oct 1, 2024
firestack
commented
Oct 1, 2024
There was a problem hiding this comment.
I feel like I may have missed something, but this looks great, thank you @hannahpurcell!!!
I can't approve my own PR so here's a comment 😅
firestack
force-pushed
the
kf/asn/dn/fe-notifications
branch
from
35dcb01 to
c9fdce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: https://app.asana.com/0/1203014709808707/1208393164852689/f
This creates the frontend part of notifications work, it's independent of other work because the parsing will not be triggered until the detour notification data is live and being sent.
Todo: