fix(ex/test): make tests against user data dynamic #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/feat/fix-user-tests
branch
from
7da119f to
335f4bb
Compare
firestack
force-pushed
the
kf/feat/fix-user-tests
branch
from
335f4bb to
0e5797c
Compare
firestack
force-pushed
the
kf/feat/fix-user-tests
branch
from
0e5797c to
d6093ab
Compare
* fix(ex/test/conn-case): remove redundant `User.upsert`'s * feat(ex/test/conn-case): make default user dynamic from factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few tests which assume what user information they're going to get, but #2864 "revealed" that we hardcode the user for
ConnCase, but with #2873 we can now generate dynamic users, so this fixes the tests so that we can dynamically create users.