Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editable directions in state machine #2880

Merged
merged 10 commits into from
Oct 31, 2024

Conversation

hannahpurcell
Copy link
Collaborator

@hannahpurcell hannahpurcell commented Oct 23, 2024

@hannahpurcell hannahpurcell requested a review from a team as a code owner October 23, 2024 18:17
@firestack
Copy link
Member

I'm hesitant to merge this before we're about to make changes to how detour directions are edited, so we can avoid any backend migrations, does this seem like an issue to you?

@hannahpurcell
Copy link
Collaborator Author

I'm hesitant to merge this before we're about to make changes to how detour directions are edited, so we can avoid any backend migrations, does this seem like an issue to you?

Ahhhh definitely an issue. Would this resolve our problem: I add a frontend / state-machine handler for when editedDirections was not previously initialized, that field should be initialized when the active / past detour is opened?

@hannahpurcell
Copy link
Collaborator Author

Ahhhh definitely an issue.

Fixed here

Base automatically changed from hp/rename-copy-detour-text to main October 31, 2024 15:29
@hannahpurcell hannahpurcell merged commit ce2ea77 into main Oct 31, 2024
9 checks passed
@hannahpurcell hannahpurcell deleted the hp/editable-directions-in-state-machine branch October 31, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants