feat: Detour serializer #2899
Merged
feat: Detour serializer #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm curious to see this! But I don't see any usage of |
Yeah, I suppose I should have left my log in there as explanation, especially since I've had subsequent merges. I'll add it back in for discussion / testing. I can remove if we deem it too noisy for Splunk |
hannahpurcell
force-pushed
the
hp/detour-serializer
branch
from
6f8da9a to
5ff2515
Compare
hannahpurcell
force-pushed
the
hp/detour-serializer
branch
from
5ff2515 to
edad323
Compare
firestack
requested changes
Nov 12, 2024
firestack
reviewed
Nov 12, 2024
firestack
reviewed
Nov 12, 2024
firestack
reviewed
Nov 12, 2024
hannahpurcell
force-pushed
the
hp/detour-serializer
branch
from
028dbc6 to
c646184
Compare
hannahpurcell
force-pushed
the
hp/detour-serializer
branch
from
ab59b73 to
e80c604
Compare
hannahpurcell
force-pushed
the
hp/detour-serializer
branch
from
e80c604 to
99c5e17
Compare
firestack
reviewed
Nov 18, 2024
Co-authored-by: Kayla Firestack <[email protected]>
firestack
reviewed
Nov 19, 2024
firestack
requested changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: https://app.asana.com/0/1205385723132845/1208675099752885
The second commit is completely optional, and maybe not even proper. I enjoyed using map_diff to help print the difference between
stateandserialized_snapshoton line 29 ofsnapshot_serde.ex. Not used in production, though, so might not be logical to commit it. On the other hand, I can see it being valuable to our production logs if we did want it.