Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts/dateTime): compare dates in UTC #2931

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(ts/dateTime): compare dates in UTC #2931

merged 1 commit into from
Jan 23, 2025

Conversation

firestack
Copy link
Member

@firestack firestack commented Jan 23, 2025 •
edited
Loading

turns out valueOf() doesn't do timezone conversions, so I've switched to getTime()
related to #2923

@firestack firestack marked this pull request as ready for review January 23, 2025 20:33
@firestack firestack requested a review from a team as a code owner January 23, 2025 20:33
@firestack firestack removed the request for review from a team January 23, 2025 20:33
@firestack firestack merged commit d2e84da into main Jan 23, 2025
54 checks passed
@firestack firestack deleted the kf/fix/dates-in-utc branch January 23, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firestack @hannahpurcell