Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ex/detours): add detour :status field, and populate from changeset #2952

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

firestack
Copy link
Member

@firestack firestack commented Feb 4, 2025

This adds a new database column and starts populating it from the changeset function.
Once we deploy this and have all instances become aware of the field. We'll then
deploy a data migration which adds this to previously made detours, so that there
are no running instances without this change to the changeset function.


Asana Ticket: https://app.asana.com/0/1203014709808707/1209213931559673

@firestack firestack marked this pull request as ready for review February 4, 2025 03:40
@firestack firestack requested a review from a team as a code owner February 4, 2025 03:40
@firestack firestack requested review from hannahpurcell and removed request for a team February 4, 2025 03:40
This adds a new database column and starts populating it from the changeset function.
Once we deploy this and have all instances become aware of the field. We'll then
deploy a data migration which adds this to previously made detours, so that there
are no running instances without this change to the changeset function
@firestack firestack force-pushed the kf/asn/store-detour-status branch from 2313474 to 7de3826 Compare February 4, 2025 03:42
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a single note, looks great!

lib/skate/detours/db/detour.ex Show resolved Hide resolved
@firestack firestack merged commit 4c180c1 into main Feb 6, 2025
15 checks passed
@firestack firestack deleted the kf/asn/store-detour-status branch February 6, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants