Refactor: Move StopTimeUpdates storage into a new GenServer #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyqrose
reviewed
Mar 3, 2020
lib/realtime/server.ex
Outdated
| @spec update( | ||
| {:stop_time_updates, StopTimeUpdates.stop_time_updates_by_trip()}, | ||
| GenServer.server() | ||
| ) :: term() | ||
| def update(update_term, server \\ __MODULE__) | ||
|
|
||
| def update({:vehicle_positions, vehicles_by_route_id, shuttles}, server) do |
There was a problem hiding this comment.
Server.update() can shed its :vehicle_positions tag now.
| stop_time_updates_by_trip: StopTimeUpdates.stop_time_updates_by_trip() | ||
| } | ||
|
|
||
| defstruct stop_time_updates_by_trip: [] |
There was a problem hiding this comment.
Suggested change
| defstruct stop_time_updates_by_trip: [] | |
| defstruct stop_time_updates_by_trip: %{} |
arkadyan
force-pushed
the
mss-stu-genserver
branch
from
348bbf0 to
9641c43
Compare
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 97.42% 97.42% -0.01%
==========================================
Files 162 163 +1
Lines 3657 3649 -8
Branches 485 485
==========================================
- Hits 3563 3555 -8
Misses 90 90
Partials 4 4
Continue to review full report at Codecov.
|
skyqrose
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana ticket: Refactor: Move StopTimeUpdates storage into a new GenServer