Add "New" indicator to search result cards #523
Conversation
For buses that have logged in within the last 30 minutes.
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
=======================================
Coverage 97.48% 97.49%
=======================================
Files 170 171 +1
Lines 3818 3831 +13
Branches 523 526 +3
=======================================
+ Hits 3722 3735 +13
Misses 92 92
Partials 4 4
Continue to review full report at Codecov.
|
|
Looks great, some vehicle info looked incorrect due to the data issues we're having (no trip headsigns displayed on active vehicles), but that seems separate from this pr. One subtle detail to add. Can we change the dropshadow to the new cards to this: |
| @@ -120,6 +120,72 @@ describe("SearchResults", () => { | |||
| expect(tree).toMatchSnapshot() | |||
| }) | |||
|
|
|||
| test("renders vehicles that have logged in within the past 30 minutes", () => { | |||
There was a problem hiding this comment.
A name like "shows the new badge for vehicle that have logged in within the past 30 minutes" would better indicate why we need the test.
assets/css/_properties_list.scss
Outdated
| @@ -28,5 +28,9 @@ | |||
| .m-properties-list__property--last-login & { | |||
| color: $color-font-grey; | |||
| font-size: 0.75rem; | |||
|
|
|||
| .m-search-results__card--new & { | |||
There was a problem hiding this comment.
Either _properties_list.scss needs a .m-search-results selector, or _search_results.scss needs a .m-properties-list selector. I think I'd rather this be in _search_results.scss and have the parent know the details about its child, than to have it here where the child would need to know details about its parent.
There was a problem hiding this comment.
Yeah, I went back and forth, but I agree with you, that's better.
|
@ingridpierre thanks, updated that box shadow. |
arkadyan
force-pushed
the
mss-new-indicator
branch
from
26cb161 to
8f4eebb
Compare
arkadyan
force-pushed
the
mss-new-indicator
branch
from
8f4eebb to
76f37d4
Compare
|
Just wanted to let you know @arkadyan I took a look and this ticket looks great! |
For buses that have logged in within the last 30 minutes.
Asana ticket: Add "New" indicator to search result cards for buses that have logged in within last 30 min