Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request decoration for Azure DevOps Services #102

Closed
RobinDink opened this issue Feb 25, 2020 · 17 comments
Closed

Pull request decoration for Azure DevOps Services #102

RobinDink opened this issue Feb 25, 2020 · 17 comments
Labels
enhancement New feature or request

Comments

@RobinDink
Copy link

Hey @mc1arke,

since you closed the other issue and the 1.3.0-release covers everything but Azure DevOps, I hope you don't mind me opening a new issue for it?
I would kindly request pull request decoration for Azure DevOps Services :).

Cheers,
Robin

@mc1arke mc1arke added the enhancement New feature or request label Feb 25, 2020
Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 8, 2020
mc1arke#102 add Azure object class and small refactoring
Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 10, 2020
mc1arke#102 add azure thread with issue
Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 11, 2020
mc1arke#102 add: closed issue in sonar, resolve in Azure
Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 11, 2020
Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 11, 2020
mc1arke#102 small refactoring
Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 12, 2020
@Iloer
Copy link

Iloer commented Mar 12, 2020

hi @RobCoPKC
Please check the solution from this thread on your server.
Plugin version: sonarqube-community-branch-plugin-1.2.1-SNAPSHOT
SonarQube version 8.1.0

@RobinDink
Copy link
Author

I just installed it and don't see any option to pick Azure DevOps as provider?

image

@Iloer
Copy link

Iloer commented Mar 13, 2020

@RobinDink
Copy link
Author

So I have to update to SonarQube 8.1?

@Iloer
Copy link

Iloer commented Mar 13, 2020

Yes.

Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 15, 2020
Iloer referenced this issue in Iloer/sonarqube-community-branch-plugin Mar 16, 2020
Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 16, 2020
Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 16, 2020
mc1arke#102 enum to UPPERCASE
Iloer added a commit to Iloer/sonarqube-community-branch-plugin that referenced this issue Mar 30, 2020
mc1arke#102 attempt to close comment in AzureDevOps by issue.key
@pratikibm
Copy link

Build branch
image

on document: https://docs.sonarqube.org/8.1/analysis/pr-decoration/

Hi Iloer,
I am not able to generate jar file could you please attached here.

@pratikibm
Copy link

So I have to update to SonarQube 8.1?

will it work for 8.2 as well?

@Iloer
Copy link

Iloer commented Apr 9, 2020

Hi @pratikibm, i'm attaching .jar
sonarqube-community-branch-plugin-1.2.1-SNAPSHOT.zip

I didn’t check on 8.2, but judging by the discussion history, it should work

@pratikibm
Copy link

Hi @pratikibm, i'm attaching .jar
sonarqube-community-branch-plugin-1.2.1-SNAPSHOT.zip

I didn’t check on 8.2, but judging by the discussion history, it should work

Thanks @Iloer , I tried it on 8.2, however I can see ALM with Azure DevOps server option but there is no option of Pull request decoration.

@Iloer
Copy link

Iloer commented Apr 10, 2020

brief instruction
1.
image

image

@cescidistus
Copy link

cescidistus commented Apr 10, 2020

hello @pratikibm ,

I success to build a version for 8.2. There is a little error on project binding manipulation.

On file GetBindingAction.java, when you call dbClient.projectAlmSettingDao().selectByProject(dbSession,projectDto), projectDto need to be a ProjectDto and not a ComponentDto on version 8.2

Same on file DeleteBindingAction.java

I don't know how to do, if I have to make a pull request on your branch, and I don't know how to make the two version work since I only have the 8.2 version.

To get the project, I add that row
ComponentDto project = componentFinder.getByKey(dbSession, projectKey); ProjectDto projectDto = componentFinder.getProjectByKey(dbSession, projectKey);

I attache built version for 8.2
sonarqube-community-branch-plugin-1.2.1-SNAPSHOT.zip

@jcuzzi
Copy link
Contributor

jcuzzi commented Jun 30, 2020

Take a look at #202 . It is working for me using SonarQube 8.2 with Azure DevOps. There are a few required properties that need to be set in the SonarQube Prepare task in the Azure Build Pipeline which are mentioned in the PR.

@raschmitt
Copy link

raschmitt commented Sep 28, 2020

Can anyone confirm if the proposed solution works on 7.9.1?

@bbarman4u
Copy link

Can any one please confirm if this Works for the Azure DevOps Services (The Cloud Hosted Version) and not only for the Server version (Self Hosted) since the original issue is stated as open yet I noticed comments on some solutions listed but seems to be only for the server edition ?

@jcuzzi
Copy link
Contributor

jcuzzi commented Oct 24, 2020

Can any one please confirm if this Works for the Azure DevOps Services (The Cloud Hosted Version) and not only for the Server version (Self Hosted) since the original issue is stated as open yet I noticed comments on some solutions listed but seems to be only for the server edition ?

It works for the cloud hosted version too.

@bbarman4u
Copy link

Can any one please confirm if this Works for the Azure DevOps Services (The Cloud Hosted Version) and not only for the Server version (Self Hosted) since the original issue is stated as open yet I noticed comments on some solutions listed but seems to be only for the server edition ?

It works for the cloud hosted version too.

@jcuzzi Thanks for the information, I will try this out.

@jcuzzi
Copy link
Contributor

jcuzzi commented Dec 17, 2020

@mc1arke this issue can probably be closed since the feature was released.

@mc1arke mc1arke closed this as completed Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants