Add images base URL property

[Brialius]

Fix #130

[Brialius]

@don-vip please take a look

[Brialius]

Example of base URL: https://raw.githubusercontent.com/mc1arke/sonarqube-community-branch-plugin/master/src/main/resources/static

[don-vip]

Please also document the property in README. I removed it, it must be restored.

[Brialius]

Please also document the property in README. I removed it, it must be restored.

Thanks for review!

Instead of previous approach I made new property configurable via server UI with appropriate field description: https://github.com/mc1arke/sonarqube-community-branch-plugin/pull/150/files#diff-6b77d55ef12cf09f58f256a700f17effR93-R97

But you are right, maybe an explanation in the README could be useful to get the clue about new property usage.

[4n4n4s]

Hi @Brialius @don-vip
so adding https://raw.githubusercontent.com/SonarSource/sonarcloud-github-static-resources/gh-pages/v2 as base URL should work fine right?

[Brialius]

Hi @Brialius @don-vip
so adding https://raw.githubusercontent.com/SonarSource/sonarcloud-github-static-resources/gh-pages/v2/ as base URL should work fine right?

Hey @4n4n4s
I suppose any storage with the same folders structure and images inside should work fine.

Pls notice that there is no trailing slash in base URL

[4n4n4s]

Pls notice that there is no trailing slash in base URL

Maybe we should remove it in case someone configures it with a slash to prevent misconfiguration

[Brialius]

Pls notice that there is no trailing slash in base URL

Maybe we should remove it in case someone configures it with a slash to prevent misconfiguration

@4n4n4s
fixed

[Brialius]

@don-vip property description is added to README

[Brialius]

@mc1arke could you please take a look at this PR?

[mc1arke]

Thanks for the great contribution. I'm generally happy with your changes, but want a discussion on the points I've raised before merging.