Fix problem with unprocessed Pull Requests in SonarQube #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid unprocessed new Pull Requests for listing in projects - Add test for that use case
|
@mc1arke will this be in release 1.15.0? |
mc1arke
requested changes
Dec 29, 2023
| @@ -177,6 +177,92 @@ void shouldExecuteRequestWithValidParameter() { | |||
| assertThat(messageArgumentCaptor.getValue()).usingRecursiveComparison().isEqualTo(expected); | |||
| } | |||
|
|
|||
| @Test | |||
| void shouldExExcludePullRequestsWithoutData() { | |||
| @@ -115,12 +115,15 @@ private static void checkPermission(ProjectDto project, UserSession userSession) | |||
|
|
|||
| private static void addPullRequest(ProjectPullRequests.ListWsResponse.Builder response, BranchDto branch, Map<String, BranchDto> mergeBranchesByUuid, | |||
| @Nullable LiveMeasureDto qualityGateMeasure, @Nullable String analysisDate) { | |||
| DbProjectBranches.PullRequestData pullRequestData = branch.getPullRequestData(); | |||
|
|
|||
| if (pullRequestData == null) return; | |||
There was a problem hiding this comment.
Please use curly braces on all if statements
There was a problem hiding this comment.
Sure. I will add them in the new changes.
|
I'm superceding this with #847 since the Pull Request data fields are not mandatory and I'd rather we didn't end up with data in the database that wasn't visible in the API, as users then don't know if they've got potentially broken data needing cleaned-up. I've also put in a fix for the root cause of the problem reported in the original issue which should mean the data is less likely to get corrupt. Thanks for the contribution though! |
|
Awesome! Thank you so much and keep the good work! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the issue #738, it's true that any type of project should not be created with a Pull Request that their target branch is not scanned yet.
But the problem comes when the Pull Request, which its target branch is scanned, is waiting for being processed when there's a heavy project in progress status in the Background tasks section. Because SonarQube didn't add the proper Pull Request data to the project until is processed, we have the same problem as was described in the issue mentioned before, even when we have the target branch scan.
So the changes that are added in this Pull Request are simple:
If there's any doubt, please, use this Pull Request for the discussion.