fix(plugin): we're handling cache-control (#451)

mcansh · Oct 29, 2024 · 54fff80 · 54fff80
1 parent 3d467eb
commit 54fff80
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/.changeset/bright-pigs-promise.md b/.changeset/bright-pigs-promise.md
@@ -0,0 +1,5 @@
+---
+"@mcansh/remix-fastify": patch
+---
+
+Make cache-control headers work again.
diff --git a/examples/basic/server.js b/examples/basic/server.js
@@ -54,7 +54,7 @@ if (process.env.NODE_ENV === "production") {
     prefix: "/",
     wildcard: false,
     decorateReply: false,
-    cacheControl: true,
+    cacheControl: false,
     dotfiles: "allow",
     etag: true,
     serveDotFiles: true,
@@ -67,18 +67,12 @@ await app.register(fastifyStatic, {
   root: BUILD_DIR,
   prefix: "/",
   wildcard: false,
-  cacheControl: true,
+  cacheControl: false,
   dotfiles: "allow",
   etag: true,
   serveDotFiles: true,
   lastModified: true,
-  setHeaders(res, filepath) {
-    let isAsset = filepath.startsWith(BUILD_DIR);
-    res.setHeader(
-      "cache-control",
-      isAsset ? ASSET_CACHE_CONTROL : DEFAULT_CACHE_CONTROL,
-    );
-  },
+  setHeaders,
 });
 
 app.register(async function createRemixRequestHandler(childServer) {

diff --git a/packages/remix-fastify/src/plugin.ts b/packages/remix-fastify/src/plugin.ts
@@ -133,7 +133,7 @@ export const remixFastify = fp<RemixFastifyOptions>(
         root: BUILD_DIR,
         prefix: basename,
         wildcard: false,
-        cacheControl: true,
+        cacheControl: false, // required because we are setting custom cache-control headers in setHeaders
         dotfiles: "allow",
         etag: true,
         serveDotFiles: true,