Add arbitrary count method #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks were failing to compile due to a couple of changes in the rest of the library. Signed-off-by: Nick Stevens <[email protected]>
The counter decrement metric actually needs 5 characters to store the constant part of the string to account for the "-" sign on "-1". This wasn't breaking anything, but the String was being forced to reallocate each time. Signed-off-by: Nick Stevens <[email protected]>
Sometimes in hot-path code it is more economical to track a counter internally and only update the StatsD instance periodically. This is as opposed to using `incr` and `decr` repeatedly. This commit adds `count` method that takes an arbitrary integer value to update a counter statistic by. Signed-off-by: Nick Stevens <[email protected]>
|
Thank you for the great contributions @nastevens! |
|
Published in 0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes in hot-path code it is more economical to track a counter internally and only update the StatsD instance periodically. This is as opposed to using
incranddecrrepeatedly. So this PR adds acountmethod that takes an arbitrary integer value to update a counter statistic by.Also fixed a couple random bugs: