Change return type for time function #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mcasper,
Sorry, i realize that the implementation i did was not so correct. The problem is that we don't want the "domain" function to not return in case the lib had communication problems with datadog. If there's an error the result should be returned anyway. Wdyt?
The alternatives for the return type are:
TimeResult
with inner fieldsresult: T
anderror: Option<Error>
(T, Option<Error>)
Thank you in advance and sorry for the inconvenience.