Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: Update rand and rand_core to 0.8 and 0.6 #107

Merged
merged 1 commit into from
Feb 14, 2021

Conversation

mxinden
Copy link
Contributor

@mxinden mxinden commented Feb 11, 2021

See rand changelog and rand_core changelog.

Thanks for maintaining snow!

@mcginty
Copy link
Owner

mcginty commented Feb 14, 2021

Thanks!

@mcginty mcginty merged commit 4cb583f into mcginty:master Feb 14, 2021
@mxinden
Copy link
Contributor Author

mxinden commented Feb 14, 2021

Thanks @mcginty for merging this pull request, updating all remaining outdated dependencies and cutting a release.

As far as I can tell v0.7.3 includes breaking changes and should thus not have been a patch release, but a minor release (v0.8.0). More specifically this crate exposes parts of rand on its public API. rand introduced breaking changes between v0.7 and v0.8 and thus snow introduces breaking changes between v0.7.2 and v0.7.3. The v0.7.3 snow release thus breaks any builds directly depending on both snow and rand, e.g. the rust-libp2p project.

@mcginty could you yank v0.7.3 and instead release the same source code as v0.8.0?

@mcginty
Copy link
Owner

mcginty commented Feb 15, 2021

@mxinden oh wow, yep. Yanked. I'll hold these changes until v0.8.0 along with these last few open PRs.

Sorry if that caused any annoyances in your project.

@mxinden
Copy link
Contributor Author

mxinden commented Feb 15, 2021

Yanked

Thank you for the swift resolution.

I'll hold these changes until v0.8.0 along with these last few open PRs.

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants