Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gpt 4 turbo #1672

Merged
merged 3 commits into from
Apr 17, 2024
Merged

update gpt 4 turbo #1672

merged 3 commits into from
Apr 17, 2024

Conversation

fbec76
Copy link
Contributor

@fbec76 fbec76 commented Apr 16, 2024

Updated GPT-4 Turbo from the preview version to the production version.

@fbec76 fbec76 mentioned this pull request Apr 16, 2024
@brajeshyadav84
Copy link

are we not supporting gpt-4-turbo-preview?
or we can add new modal on top gpt-4-turbo and keep preview as well.

@mckaywrigley mckaywrigley merged commit 5f89405 into mckaywrigley:main Apr 17, 2024
Copy link
Contributor

@tim13246879 tim13246879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR pretty much replaces the string "gpt-4-turbo-preview" with "gpt-4-turbo" in the codebase. There are other changes that should be made to ensure a smooth transition to the new model though. These are documented in individual comments below, and at #1663.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imageInput should be true as the newest model accepts images.

UPDATED time should also be changed for better documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #1676, this migration file should not be changed. Instead, new migrations should be applied.

@HowieG
Copy link

HowieG commented Apr 17, 2024

Hey @fbec76 , like @tim13246879 seems to explain, I had an issue caused by this change. Chatbot UI was not working at all for me. Checked the commit history and saw this change. I put two and two together and changed my selected model from gpt-4-turbo-preview to gpt-4-turbo and it worked. Here's a replay of what happened. After I changed it gpt-4-turbo-preview was no longer an option so it must've been cached or something, or maybe what @tim13246879 says. Don't have too much time to look into it now but this recording should be helpful.

https://jam.dev/c/534fea88-6411-41ed-b9eb-9b95f47b7fcf

@fbec76
Copy link
Contributor Author

fbec76 commented Apr 18, 2024

@tim13246879 ,
you are right with all of your points.
We should revert this MR and add the production model as a new model to the preview one.
So we ensure the support of preview chats and functionality.

So, @mckaywrigley please revert this MR!

Edit: The Revert is mentioned in this MR: #1678

mmahmad added a commit to mmahmad/chatbot-ui that referenced this pull request Apr 22, 2024
mckaywrigley pushed a commit that referenced this pull request Apr 22, 2024
leovvay pushed a commit to kissMyApps-tlm/_KMA_kissmychat that referenced this pull request May 19, 2024
* update gpt 4 turbo

* Add gpt-4-turbo mckaywrigley#1659

* Add gpt-4-turbo mckaywrigley#1659
leovvay pushed a commit to kissMyApps-tlm/_KMA_kissmychat that referenced this pull request May 19, 2024
Chr96er pushed a commit to Chr96er/chatbot-ui that referenced this pull request May 26, 2024
* update gpt 4 turbo

* Add gpt-4-turbo mckaywrigley#1659

* Add gpt-4-turbo mckaywrigley#1659
Chr96er pushed a commit to Chr96er/chatbot-ui that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants