Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix google model name and add gemini 1.5 flash #1778

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

meetpateltech
Copy link
Contributor

@meetpateltech meetpateltech commented Jun 7, 2024

This PR includes the following changes:

  1. Rename "Gemini Flash" to "Gemini 1.5 Pro" because the model name used is "Gemini 1.5 Pro," but it is currently named "Gemini Flash."
  2. I made the 'imageInput' property true, as 'Gemini 1.5 Pro' supports image input.
  3. Add "Gemini 1.5 Flash" with the correct model ID and name. It is similar to "Gemini 1.5 Pro" but faster in comparison.

🚀 This description was created by Ellipsis for commit 04c42ba

Summary:

This PR renames 'Gemini Flash' to 'Gemini 1.5 Pro', updates its image input capability, and adds a new model 'Gemini 1.5 Flash' with appropriate settings and type definitions.

Key points:

  • Rename Gemini Flash to Gemini 1.5 Pro in lib/models/llm/google-llm-list.ts.
  • Update imageInput to true for Gemini 1.5 Pro.
  • Add Gemini 1.5 Flash with settings in lib/chat-setting-limits.ts and lib/models/llm/google-llm-list.ts.
  • Update types/llms.ts to include gemini-1.5-flash.

Generated with ❤️ by ellipsis.dev

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 04c42ba in 56 seconds

More details
  • Looked at 74 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. lib/chat-setting-limits.ts:49
  • Draft comment:
    The settings for "Gemini 1.5 Flash" are identical to "Gemini 1.5 Pro". If "Gemini 1.5 Flash" is intended to be faster, consider adjusting its settings (e.g., MAX_TOKEN_OUTPUT_LENGTH or MAX_CONTEXT_LENGTH) to reflect its enhanced capabilities.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_yvZeUqoVb7ZTWBgZ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@faraday
Copy link
Contributor

faraday commented Jun 7, 2024

Tested this locally, working fine.

@mckaywrigley mckaywrigley merged commit cf0fe63 into mckaywrigley:main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants