Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supporting https #30

Merged
merged 4 commits into from
Jun 27, 2016
Merged

supporting https #30

merged 4 commits into from
Jun 27, 2016

Conversation

GlenTiki
Copy link
Collaborator

fixes #28

GlenTiki
GlenTiki reviewed Jun 27, 2016
View reviewed changes
lib/myhttp.js
@@ -85,7 +87,12 @@ function Client (opts) {
inherits(Client, EE)

Client.prototype._connect = function () {
this.conn = net.connect(this.opts.port, this.opts.hostname)
if (this.secure) {
this.conn = tls.connect(this.opts.port, this.opts.hostname, { rejectUnauthorized: false })
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we allow users to specify rejectUnauthorized?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relevant, CTRL-F rejectUnauthorized: https://nodejs.org/api/https.html#https_https_createserver_options_requestlistener

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for a load tester it's good to not validate certificates.

@mcollina
Copy link
Owner

Can you please check the performance of our ssl impl with the one of wrk?

mcollina
mcollina reviewed Jun 27, 2016
View reviewed changes
README.md
@@ -4,8 +4,8 @@

![demo](https://raw.githubusercontent.com/mcollina/autocannon/master/demo.gif)

An HTTP benchmarking tool written in node, greatly inspired by
[wrk][wrk] and [wrk2][wrk2], with support to HTTP pipelining.
A HTTP benchmarking tool written in node, greatly inspired by [wrk][wrk]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably say that this is a HTTP/1.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@GlenTiki
Copy link
Collaborator Author 

Glens-MBP-2:os glen$ ./autocannon/autocannon.js -c 1000 -d 30 https://localhost:3000
Running 30s test @ https://localhost:3000
1000 connections

Stat         Avg     Stdev     Max
Latency (ms) 73.46   89.64     2911
Req/Sec      13609.3 3602.58   15591
Bytes/Sec    1.52 MB 403.83 kB 1.77 MB

408k requests in 31s, 45.73 MB read
28 errors (0 timeouts)
Glens-MBP-2:os glen$ ./wrk/wrk -c 1000 -d 30 https://localhost:3000
Running 30s test @ https://localhost:3000
  2 threads and 1000 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     6.76ms    6.86ms 119.26ms   95.55%
    Req/Sec     5.64k     2.72k    9.08k    60.66%
  309316 requests in 30.03s, 33.04MB read
  Socket errors: connect 18898, read 16, write 0, timeout 80
Requests/sec:  10301.21
Transfer/sec:      1.10MB

@mcollina
Copy link
Owner

Can you please check what's going on with the high latency?

@mcollina mcollina merged commit a8e4106 into mcollina:master Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

https support?
2 participants
@GlenTiki @mcollina