Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle large response body correctly #301

Merged
merged 3 commits into from
Nov 17, 2020
Merged

fix: handle large response body correctly #301

merged 3 commits into from
Nov 17, 2020

Conversation

salmanm
Copy link
Collaborator

@salmanm salmanm commented Nov 17, 2020 •
edited
Loading

Supersedes https://github.com/mcollina/autocannon/pull/276/files
Fixes #275

Coincidently this fix also over-rides the code changes one done in #287 but the fix still works.

  • Refactored response body parsing. It now collects body chunks until kOnMessageComplete fires and then it calls onResponse and emit response
  • Added test to cover the same

@salmanm salmanm marked this pull request as ready for review November 17, 2020 14:42
@salmanm salmanm changed the title WIP: fix: handle large response body correctly fix: handle large response body correctly Nov 17, 2020
mcollina
mcollina approved these changes Nov 17, 2020
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 31fe858 into mcollina:master Nov 17, 2020
@salmanm salmanm deleted the pr/276-1 branch November 18, 2020 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response body is not handled correctly
2 participants
@salmanm @mcollina