Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for passing in custom tlsOptions #303

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Adding support for passing in custom tlsOptions #303

merged 1 commit into from
Nov 18, 2020

Conversation

chiragpat
Copy link
Contributor

Why
Currently there is no way to pass custom client certificates through autocannon if the server being benchmarked requires client certificate validation

How

  • Adding support in the js API to pass in tlsOptions through to the httpClient.
  • Updated the test tls server to echo the client certificate email as a way to verify things are working correctly

mcollina
mcollina approved these changes Nov 18, 2020
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4544c84 into mcollina:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiragpat @mcollina