Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for initializing custom context object #304

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

salmanm
Copy link
Collaborator

@salmanm salmanm commented Nov 19, 2020

Fixes #279

  • Added initialContext option which is used to initialize context instead of empty object
  • Covered with tests
  • Updated readme.

lib/requestIterator.js Show resolved Hide resolved
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Owner

can you fix the conflicts?

@salmanm salmanm merged commit 0fceeda into mcollina:master Nov 19, 2020
@salmanm salmanm deleted the fix/279 branch November 19, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setupRequest is being called before setupClient
2 participants