Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add contributor #312

Merged
merged 1 commit into from
Dec 11, 2020
Merged

chore: add contributor #312

merged 1 commit into from
Dec 11, 2020

Conversation

salmanm
Copy link
Collaborator

@salmanm salmanm commented Dec 9, 2020

No description provided.

README.md Outdated
@@ -507,7 +507,7 @@ If you are using autocannon or you have any questions, let us know: [Gitter](htt

## License

Copyright [Matteo Collina](https://github.com/mcollina) and other contributors, Licensed under [MIT](./LICENSE).
Copyright [Matteo Collina](https://github.com/mcollina), [Salman Mitha](https://github.com/salmanm) and other contributors, Licensed under [MIT](./LICENSE).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this? I would prefer not to alter the copyright notice.

I'm happy to list both you and @GlenTiki in another section the README, similar to what fastifydoes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok sure.

@salmanm salmanm force-pushed the add-contrib branch 3 times, most recently from 1a1a794 to fc499bb Compare December 11, 2020 12:48
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit fabd900 into master Dec 11, 2020
@salmanm salmanm deleted the add-contrib branch December 11, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants