Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to fix intermittent test failures #313

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

salmanm
Copy link
Collaborator

@salmanm salmanm commented Dec 9, 2020

Builds are still not very stable on windows CI.
Although we tried running on windows machine locally but could never see a test fail.

In httpClient.test.js

It seems like these two tests in httpClient.test.js are failing intermittently.

  • client should emit a timeout when no response is received
  • client should emit 2 timeouts when no responses are received

This PR increases wait time from 2500 to 2800, just so slow windows boxes don't choke up.

in runRate.test.js

All 3 scenarios of the following test are failing intermittently.

  • run should only send the expected number of requests per second

I presume the duration may be coming as slightly more than 4.5 seconds due to slow windows box and becomes 5 due to Math.round. But we're asserting it with 4, so I've changed it to Math.floor instead.

@salmanm salmanm marked this pull request as ready for review December 9, 2020 07:51
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, might be the right time!

@mcollina mcollina merged commit 2d43e9a into master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants