fix: attempt to fix intermittent test failures #313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds are still not very stable on windows CI.
Although we tried running on windows machine locally but could never see a test fail.
In
httpClient.test.js
It seems like these two tests in
httpClient.test.js
are failing intermittently.This PR increases wait time from 2500 to 2800, just so slow windows boxes don't choke up.
in
runRate.test.js
All 3 scenarios of the following test are failing intermittently.
I presume the
duration
may be coming as slightly more than 4.5 seconds due to slow windows box and becomes5
due toMath.round
. But we're asserting it with4
, so I've changed it toMath.floor
instead.