fix(324): Show error when no worker support is found #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmanm
commented
Jan 20, 2021
test/run.test.js
Outdated
| @@ -366,7 +366,7 @@ test('run should accept a unix socket/windows pipe', (t) => { | |||
| }) | |||
|
|
|||
| for (let i = 1; i <= 5; i++) { | |||
| test(`run should count all ${i}xx status codes`, (t) => { | |||
| test(`run should count all ${i}xx status codes`, { skip: true }, (t) => { | |||
There was a problem hiding this comment.
Has to disable this temporarily as it fails consistently only on node 15.6.0.
We may need to investigate this separately. Will create an issue for it.
There was a problem hiding this comment.
Can you please make it skip only on node v15?
mcollina
requested changes
Jan 20, 2021
test/run.test.js
Outdated
| @@ -366,7 +366,7 @@ test('run should accept a unix socket/windows pipe', (t) => { | |||
| }) | |||
|
|
|||
| for (let i = 1; i <= 5; i++) { | |||
| test(`run should count all ${i}xx status codes`, (t) => { | |||
| test(`run should count all ${i}xx status codes`, { skip: true }, (t) => { | |||
There was a problem hiding this comment.
Can you please make it skip only on node v15?
Co-authored-by: Matteo Collina <[email protected]>
mcollina
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324