Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Total reqs sent counted #72

Merged
merged 5 commits into from
Jul 21, 2016
Merged

Total reqs sent counted #72

merged 5 commits into from
Jul 21, 2016

Conversation

GlenTiki
Copy link
Collaborator

Fixes #71

mcollina
mcollina reviewed Jul 20, 2016
View reviewed changes
lib/run.js
latency: addPercentiles(latencies, histAsObj(latencies)),
throughput: histAsObj(throughput, totalBytes),
totalRequests: totalRequests,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put it inside the requests object, as sent. Does it make sense?

@davidmarkclements ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename

@mcollina
Copy link
Owner

Does it affect performance?

@GlenTiki
Copy link
Collaborator Author

No perf damage

@mcollina
Copy link
Owner

builds are failing

@GlenTiki
Copy link
Collaborator Author

I went to grab food after updating the var, just realised I never updated
tests 😬 my bad, will fix asap

On 20 Jul 2016 5:23 p.m., "Matteo Collina" [email protected] wrote:

builds are failing

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#72 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGlmB2q1Fjk_bmrs0p71UEVMigj2eZe5ks5qXkuUgaJpZM4JQ7AN
.

mcollina
mcollina reviewed Jul 21, 2016
View reviewed changes
lib/run.js
latency: addPercentiles(latencies, histAsObj(latencies)),
throughput: histAsObj(throughput, totalBytes),
sent: totalRequests,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I meant was result.requests.sent :).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh. I forgot to put the helper lib hdr-histogram-percentiles-obj in, is it okay if I do that too?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do!

@mcollina
Copy link
Owner

LGTM, I'd release as minor

@GlenTiki GlenTiki merged commit f726c52 into mcollina:master Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GlenTiki @mcollina