Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual rec management #856 #898

Merged
merged 5 commits into from
Nov 29, 2016

Conversation

RafaFP
Copy link
Contributor

@RafaFP RafaFP commented Oct 13, 2016

Created a page for management of recordings (manage/recordings)

Resolves #856

RafaFP added 5 commits October 5, 2016 15:19
there are currently the title, description, 4 buttons (publish, unpublish, edit and delete)
the filter is the exact same as the Spaces filter
searching also get what is on the description of the recording now
icons showing have been chaged to make it only show publish/unpublish/playbacklist when the recording is available
…m name, date of the recording and recording id

imrpoved the search to find by recording id and also by name of the room
…rch using search_by_terms

created specs for manage/recordings new implementation

TODO: create more specs for manage/recordings (integration)
improved and fixed logic for published and unpublished icons and links
@@ -9,6 +9,8 @@ class ManageController < ApplicationController
before_filter :authenticate_user!
authorize_resource :class => false

load_and_authorize_resource :find_by => :recordid, :class => "BigbluebuttonRecording"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed?

@daronco daronco merged commit 6577347 into mconf:master Nov 29, 2016
daronco added a commit that referenced this pull request Nov 29, 2016
Order recordings by "start_time DESC" instead of name, improve the visual
of the new page and the strings a bit.
daronco added a commit that referenced this pull request Nov 29, 2016
Was using a join to filter recordings that had at least one playback. Even
though it worked, it was returning the same recording multiple times.
Made the queries simpler and moved them to scopes in the model.

Complements PR #898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants