-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Individual rec management #856 #898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are currently the title, description, 4 buttons (publish, unpublish, edit and delete) the filter is the exact same as the Spaces filter
searching also get what is on the description of the recording now icons showing have been chaged to make it only show publish/unpublish/playbacklist when the recording is available
…m name, date of the recording and recording id imrpoved the search to find by recording id and also by name of the room
…rch using search_by_terms created specs for manage/recordings new implementation TODO: create more specs for manage/recordings (integration)
improved and fixed logic for published and unpublished icons and links
daronco
reviewed
Nov 29, 2016
@@ -9,6 +9,8 @@ class ManageController < ApplicationController | |||
before_filter :authenticate_user! | |||
authorize_resource :class => false | |||
|
|||
load_and_authorize_resource :find_by => :recordid, :class => "BigbluebuttonRecording" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
daronco
added a commit
that referenced
this pull request
Nov 29, 2016
Order recordings by "start_time DESC" instead of name, improve the visual of the new page and the strings a bit.
daronco
added a commit
that referenced
this pull request
Nov 29, 2016
daronco
added a commit
that referenced
this pull request
Nov 29, 2016
Was using a join to filter recordings that had at least one playback. Even though it worked, it was returning the same recording multiple times. Made the queries simpler and moved them to scopes in the model. Complements PR #898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a page for management of recordings (manage/recordings)
Resolves #856