Manage spaces filters #792 #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troler sepcs TODO improve search to use search_by_terms TODO add feature spec for spaces tab, for there is none
Changed search method to be similar manage/users search_by_terms, now we can search the description and search for multiple words properly on the manage/spaces page
…to show spaces in name order
so that the highlight can show description findings on long texts and disabled spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation adds filters to the manage/spaces page
It also implements the search_by_terms function as used in /manage/users page
Adds a spec/features to test manage/spaces page
Resolves #792